Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement related to #199: add event type name validation #201

Merged
merged 2 commits into from
Jan 19, 2021

Conversation

seratch
Copy link
Member

@seratch seratch commented Jan 11, 2021

This pull request improves the event listener registration in the aim of helping developers easily understand what's wrong with message.* values for event types. ref #199

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added this to the 1.2.0 milestone Jan 11, 2021
@seratch seratch self-assigned this Jan 11, 2021
@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #201 (83ec7b8) into main (90bfe6a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
+ Coverage   91.60%   91.61%   +0.01%     
==========================================
  Files         159      159              
  Lines        4750     4760      +10     
==========================================
+ Hits         4351     4361      +10     
  Misses        399      399              
Impacted Files Coverage Δ
slack_bolt/listener_matcher/builtins.py 93.83% <100.00%> (+0.24%) ⬆️
slack_bolt/logger/messages.py 88.23% <100.00%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90bfe6a...83ec7b8. Read the comment docs.

@seratch
Copy link
Member Author

seratch commented Jan 11, 2021

@aoberoi @stevengill @mwbrooks @misscoded
We may want to add the same validation to Bolt for JS and Bolt for Java. If there is no objection to it, I am happy to work on it.

@seratch seratch modified the milestones: 1.2.0, 1.2.1 Jan 12, 2021
@seratch
Copy link
Member Author

seratch commented Jan 12, 2021

As we do not have enough time until v1.2.0 release, I will be waiting for feedback for a few more days. If this is fine, I will merge this change for v1.2.1.

@seratch
Copy link
Member Author

seratch commented Jan 15, 2021

This pull request is ready to merge. I will wait for responses from other maintainers for a few more business days before merging it. For feature parity across SDKs, I started a discussion at slackapi/bolt-js#757

@seratch seratch merged commit e042273 into slackapi:main Jan 19, 2021
@seratch seratch deleted the issue-199-detecting-invalid-event-type branch January 19, 2021 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant