Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to the latest v3.x @slack/client #529

Merged
merged 2 commits into from
Sep 11, 2018

Conversation

aoberoi
Copy link
Contributor

@aoberoi aoberoi commented Sep 10, 2018

Requirements (place an x in each [ ])

@codecov
Copy link

codecov bot commented Sep 10, 2018

Codecov Report

Merging #529 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #529   +/-   ##
=======================================
  Coverage   85.55%   85.55%           
=======================================
  Files           6        6           
  Lines         353      353           
  Branches       79       79           
=======================================
  Hits          302      302           
  Misses         29       29           
  Partials       22       22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76a03bc...498ffe4. Read the comment docs.

@aoberoi
Copy link
Contributor Author

aoberoi commented Sep 10, 2018

Blocking on internal conversation about how to handle incompatibility with node v0.12.

@aoberoi aoberoi mentioned this pull request Sep 10, 2018
2 tasks
@aoberoi aoberoi merged commit 3d6a6b9 into slackapi:master Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants