Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new canvas public API sample JSON data #1322

Merged
merged 6 commits into from
Jun 11, 2024
Merged

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Jun 10, 2024

Assembled by pinging the relevant APIs on Slack dev. Planned to be released tomorrow.

slackapi/node-slack-sdk#1813 on the node side had the response shapes generated based off of this PR.

@filmaj filmaj requested a review from seratch June 10, 2024 20:03
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.91%. Comparing base (54d924c) to head (e6427ff).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1322   +/-   ##
=========================================
  Coverage     74.91%   74.91%           
- Complexity     4129     4130    +1     
=========================================
  Files           443      443           
  Lines         12791    12791           
  Branches       1319     1319           
=========================================
+ Hits           9582     9583    +1     
+ Misses         2441     2440    -1     
  Partials        768      768           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on these! Once all my comments are resolved, you can merge these at any time. I will work on the full e2e tests tomorrow in my timezone

json-logs/samples/api/canvases.access.delete.json Outdated Show resolved Hide resolved
json-logs/samples/api/canvases.sections.lookup.json Outdated Show resolved Hide resolved
json-logs/samples/api/canvases.create.json Show resolved Hide resolved
@seratch seratch added the project:slack-api-client project:slack-api-client label Jun 11, 2024
@seratch seratch added this to the 1.39.4 milestone Jun 11, 2024
@filmaj filmaj merged commit 6f9fedd into main Jun 11, 2024
6 checks passed
@filmaj filmaj deleted the sample-canvases-apis branch June 11, 2024 04:20
@seratch seratch modified the milestones: 1.39.4, 1.40.0 Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project:slack-api-client project:slack-api-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants