-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new canvas public API sample JSON data #1322
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1322 +/- ##
=========================================
Coverage 74.91% 74.91%
- Complexity 4129 4130 +1
=========================================
Files 443 443
Lines 12791 12791
Branches 1319 1319
=========================================
+ Hits 9582 9583 +1
+ Misses 2441 2440 -1
Partials 768 768 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on these! Once all my comments are resolved, you can merge these at any time. I will work on the full e2e tests tomorrow in my timezone
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
Assembled by pinging the relevant APIs on Slack dev. Planned to be released tomorrow.
slackapi/node-slack-sdk#1813 on the node side had the response shapes generated based off of this PR.