-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for chat.postMessage API method #15
Conversation
This is super useful. Just a side note, Bot users are not authorized to call this endpoint. |
Actually, as of a few minutes ago, they are. As I mentioned over in slackapi/hubot-slack#148 this is provisional and might change but probably won't... |
🍻 👍 |
@_client.logger.debug params | ||
@_client._apiCall "chat.postMessage", params, @_onPostMessage | ||
|
||
_onPostMessage: (data) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a thought...
There are a bunch of these _on{{ApiMethod}}
methods that just call the logger. Not really bad but might be easier to just pass around the logger directly instead of a bunch of different methods that wrap it (unless there's some other purpose I'm missing).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A fair point - I was just copying the existing pattern. I'm open to other approaches here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea you definitely didn't start it here. Not a big deal, just something I noticed.
Add support for chat.postMessage API method
prep for launch
This pull request adds support for the chat.postMessage API method