Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files and comments #22

Closed
wants to merge 2 commits into from

Conversation

yahsan2
Copy link

@yahsan2 yahsan2 commented Feb 14, 2015

I added file and comment Classes.
and, I added eventCamelName function.

@paulhammond
Copy link
Contributor

Hi! thanks for sharing this!

Unfortunately some of the other changes we've just merged mean that we can't merge this as is. Would you mind updating so it's merge-able? While you're at it, you'll probably want to include the changes to add custom callbacks to your new functions (see #20 and #30 for details)

I'm also not sure about the eventCamelName function - it means it's much harder to grep the code for where a particular function is called, and it doesn't improve the readability of the code. I think

@emit @eventCamelName(message.type), f

is more confusing than:

@emit "fileCreated", f

If you can fix both I'd be happy to get this merged!

@ekmartin
Copy link
Contributor

ekmartin commented Apr 3, 2015

Are you still planning to finish this @yahsan2? Would be nice, especially since it adds file events :)

@Tehnix
Copy link

Tehnix commented May 29, 2015

Was wondering what the progress on this was? Else I might try to take a stab at this, since I would really like attachments etc to show up (am currently using @ekmartin's slack-irc integration) :)

@yahsan2 yahsan2 closed this Apr 14, 2016
aoberoi added a commit to aoberoi/node-slack-sdk that referenced this pull request Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants