-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump ws 0.4.31 -> 0.8.1 #47
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haven't experienced any issues caused by this version bump. Been running in production since around mid-June. |
Thanks, I'll check this out and confirm the upgrade looks good. |
Fix typo in getUnreadCount and getChannelsWithUnreads
Can we bump ws version please? |
Rebased with master and updated to ws 0.8.1. |
aoberoi
added a commit
to aoberoi/node-slack-sdk
that referenced
this pull request
Mar 20, 2019
Add glitch example
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the ws npm to a more recent version. Noticing quite a few reconnects / connection issues when connected for extended periods of time, so updating
ws
was low hanging fruit.Verified that the API calls and events in use by slack-client are unchanged: https://github.com/websockets/ws/blob/master/doc/ws.md
There is a change in default protocol, though:
In my testing I haven't seen any issues, but would be good to hear from the Slack folks if we should specify protocolVersion: 8.
This is definitely a critical component for the library, so I'm not in a rush to get it merged until we get more eyes on it ;)