Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump ws 0.4.31 -> 0.8.1 #47

Merged
7 commits merged into from
Dec 1, 2015
Merged

bump ws 0.4.31 -> 0.8.1 #47

7 commits merged into from
Dec 1, 2015

Conversation

vanm
Copy link
Contributor

@vanm vanm commented Jun 11, 2015

Bumps the ws npm to a more recent version. Noticing quite a few reconnects / connection issues when connected for extended periods of time, so updating ws was low hanging fruit.

Verified that the API calls and events in use by slack-client are unchanged: https://github.com/websockets/ws/blob/master/doc/ws.md

There is a change in default protocol, though:

Protocol support
Hixie draft 76 (Old and deprecated, but still in use by Safari and Opera. Added to ws version 0.4.2, but server only. Can be disabled by setting the disableHixie option to true.)
HyBi drafts 07-12 (Use the option protocolVersion: 8)
HyBi drafts 13-17 (Current default, alternatively option protocolVersion: 13)

In my testing I haven't seen any issues, but would be good to hear from the Slack folks if we should specify protocolVersion: 8.

This is definitely a critical component for the library, so I'm not in a rush to get it merged until we get more eyes on it ;)

@vanm
Copy link
Contributor Author

vanm commented Jul 20, 2015

Haven't experienced any issues caused by this version bump. Been running in production since around mid-June.

@ghost
Copy link

ghost commented Sep 29, 2015

Thanks, I'll check this out and confirm the upgrade looks good.

Fix typo in getUnreadCount and getChannelsWithUnreads
@ChrisCinelli
Copy link

Can we bump ws version please?
It is still broken on node 0.12.

@vanm vanm changed the title bump ws 0.4.31 -> 0.7.2 bump ws 0.4.31 -> 0.8.0 Nov 30, 2015
@vanm vanm changed the title bump ws 0.4.31 -> 0.8.0 bump ws 0.4.31 -> 0.8.1 Nov 30, 2015
@vanm
Copy link
Contributor Author

vanm commented Nov 30, 2015

Rebased with master and updated to ws 0.8.1.

ghost pushed a commit that referenced this pull request Dec 1, 2015
bump ws 0.4.31 -> 0.8.1
@ghost ghost merged commit ab223a4 into slackapi:master Dec 1, 2015
aoberoi added a commit to aoberoi/node-slack-sdk that referenced this pull request Mar 20, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants