-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1209 Add __all__ to __init__.py #1210
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1210 +/- ##
==========================================
- Coverage 86.55% 86.53% -0.02%
==========================================
Files 111 111
Lines 10912 10934 +22
==========================================
+ Hits 9445 9462 +17
- Misses 1467 1472 +5
Continue to review full report at Codecov.
|
In this pull request, I've fixed many mypy warnings too. That being said, it does not mean that we will use mypy for this project itself. We already use flake8 and pytype. These tools have been helping us to keep the quality at a high enough level. Spending more time for satisfying mypy is not the direction where we would like to head. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @seratch! Is there a way that we want to test that __all__
include the correct imports?
Good question! There is no way to write unit tests for it, but flake8 (linter) detects missing items if there is any. |
Cool, at least flake8 will help ensure we add them going forward! |
Summary
This pull request resolves #1209 by adding
__all__
to__init__.py
files.Category (place an
x
in each of the[ ]
)/docs-src
(Documents, have you run./scripts/docs.sh
?)/docs-src-v2
(Documents, have you run./scripts/docs-v2.sh
?)/tutorial
(PythOnBoardingBot tutorial)tests
/integration_tests
(Automated tests for this library)Requirements (place an
x
in each[ ]
)python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh
after making the changes.