Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRE-8939 Backport TxThrottler dry run mode #13687 #112

Conversation

ejortegau
Copy link
Collaborator

Description

Add support to run the vttablet transaction throttler in dry run mode.

This is a backport of upstreamed vitessio#13604

Related Issue(s)

https://jira.tinyspeck.com/browse/DRE-8938

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Roderick Yao and others added 4 commits July 5, 2023 08:56
Signed-off-by: Priya Bibra <pbibra@slack-corp.com>
Signed-off-by: 'Priya Bibra' <pbibra@slack-corp.com>
This is a backport of upstreamed vitessio#13604

Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>
Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>
@ejortegau ejortegau marked this pull request as ready for review August 2, 2023 12:33
@ejortegau ejortegau requested a review from a team as a code owner August 2, 2023 12:33
ejortegau and others added 5 commits August 2, 2023 14:38
Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>
* Empty commit to trigger CI

Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>

* `slack-vitess-r14.0.5-dsdefense`: use larger runner

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Use runner group instead

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Rename group

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Move more jobs to runner group

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* use vitess-ubuntu20 runner group

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Rever change of runner type for e2e ERS PRS new features heavy test

Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>

---------

Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com>
….5-dsdefense-tx-throttler-dry-run-mode

Signed-off-by: Eduardo J. Ortega U. <5791035+ejortegau@users.noreply.github.com>
…_heavy. (#116)

We do this because the test is taking a lot longer & failing in some cases with
the larger runner.

Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>
….5-dsdefense-tx-throttler-dry-run-mode

Signed-off-by: Eduardo J. Ortega U. <5791035+ejortegau@users.noreply.github.com>
@ejortegau ejortegau merged commit 333c488 into slack-vitess-r14.0.5-dsdefense Aug 3, 2023
@ejortegau ejortegau deleted the ejortegau/slack-vitess-r14.0.5-dsdefense-tx-throttler-dry-run-mode branch August 3, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants