Allow using planetscale's log instead of glog #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be controlled with a command flag. However, notice that using the planetscale logger means that automatic log rotation does now work, as this is not provided by planetscale's logger or the underlying zap logger, whereas it does come in with glog.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This can be controlled with a command flag. However, notice that using the planetscale logger means that automatic log rotation does now work, as this is not provided by planetscale's logger or the underlying zap logger, whereas it does come in with glog.
Usual logging continues to work without any changes:
But with the new flag, it changes to planetscale's logger:
% ./bin/vtgate -log_planetscale {"level":"info","time":"2022-11-15T11:54:32+01:00","caller":"log/log.go:96","msg":"Version: 12.0.5 (Git revision ebca7e95de branch 'eduardo_ortega_structured_logging') built on Tue Nov 15 10:59:08 CET 2022 by eduardo.ortega@eduardo-ltmnjyh.internal.salesforce.com using go1.18.8 darwin/amd64"} {"level":"error","time":"2022-11-15T11:54:32+01:00","caller":"log/log.go:98","msg":"topo_global_server_address must be configured","stacktrace":"vitess.io/vitess/go/vt/log.SetPlanetScaleLog.func5\n\tvitess.io/vitess/go/vt/log/log.go:98\ngh.neting.cc/slok/noglog.(*LoggerFunc).Errorf\n\tgh.neting.cc/slok/noglog@v0.2.0/glog.go:210\ngh.neting.cc/slok/noglog.Errorf\n\tgh.neting.cc/slok/noglog@v0.2.0/glog.go:135\ngh.neting.cc/slok/noglog.Exitf\n\tgh.neting.cc/slok/noglog@v0.2.0/glog.go:182\nvitess.io/vitess/go/vt/topo.Open\n\tvitess.io/vitess/go/vt/topo/server.go:224\nmain.main\n\tvitess.io/vitess/go/cmd/vtgate/vtgate.go:116\nruntime.main\n\truntime/proc.go:250"}Using Planetscale's logger (which under the hood is a wrapper for Uber's zap) together with
noglogas in this PR allows for an easy migration path away from glog; while also providing an initial approach to structured logging.Notice that to get this upstreamed, a different PR with slightly different code changes is necessary, as the way in which the log related CLI flags are registered is different.
Related issue
vitessio#11613