Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack-vitess-r15.0.5: update CODEOWNERS #250

Merged
merged 9 commits into from
Mar 14, 2024
Merged

slack-vitess-r15.0.5: update CODEOWNERS #250

merged 9 commits into from
Mar 14, 2024

Conversation

timvaillancourt
Copy link
Member

@timvaillancourt timvaillancourt commented Mar 12, 2024 •
edited
Loading

Description

In this PR:

  1. CODEOWNERS updated for new #team-ds-vitess squad
  2. CI removed for 5.7 and MariaDB
    • We don't use these flavours and we backport upstream-tested changes. Let's assume upstream tested it (they do)
  3. Backport Update MySQL apt package and GPG signature vitessio/vitess#14785 to fix CI failures

cc @vmogilev / @tanjinx

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@timvaillancourt
slack-vitess-r15.0.5: update CODEOWNERS and go runtime
a1714a0 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@github-actions github-actions bot added this to the v15.0.5 milestone Mar 12, 2024
@mattlord @timvaillancourt
Update MySQL apt package and GPG signature (vitessio#14785)
9040f14 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@salesforce-cla Salesforce CLA
Copy link

Thanks for the contribution! Before we can merge this, we need @mattlord to sign the Salesforce Inc. Contributor License Agreement.

@timvaillancourt
gofmt complaint
96e0b22 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt timvaillancourt requested a review from a team March 12, 2024 19:42
@timvaillancourt
make sizegen
d41daf0 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt
Update docker/bootstrap/Dockerfile.common
1a4d2f1 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt
Use go1.20.14
97dcfc4 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt
make sizegen
e4e1cbd 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt
Revert to go1.18
f4dfba7 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt timvaillancourt changed the title slack-vitess-r15.0.5: update CODEOWNERS and go runtime slack-vitess-r15.0.5: update CODEOWNERS Mar 14, 2024
@timvaillancourt timvaillancourt marked this pull request as ready for review March 14, 2024 18:00
@timvaillancourt timvaillancourt requested a review from a team as a code owner March 14, 2024 18:00
@timvaillancourt
make proto again
8128880 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
tanjinx
tanjinx approved these changes Mar 14, 2024
View reviewed changes
Copy link

@tanjinx tanjinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🥇

@tanjinx tanjinx added the v15 label Mar 14, 2024
@timvaillancourt timvaillancourt merged commit 687889c into slack-vitess-r15.0.5 Mar 14, 2024
195 of 196 checks passed
@timvaillancourt timvaillancourt deleted the codeowners-go1.22-slack-vitess-r15.0.5 branch March 14, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanjinx tanjinx tanjinx approved these changes

Assignees
No one assigned
Labels
build/release cla:missing v15
Projects
None yet
Milestone
v15.0.5
Development

Successfully merging this pull request may close these issues.
3 participants
@timvaillancourt @tanjinx @mattlord