slack-vitess-r15.0.5: backport structured logging from vitessio/vitess#11960
#270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create a function to replace glog with PlanetScale log Signed-off-by: Emad Habib <ehabib@slack-corp.com> * Add test case for replacing glog Signed-off-by: Emad Habib <ehabib@slack-corp.com> * Remove one test Signed-off-by: Emad Habib <ehabib@slack-corp.com> * Add flag for PS Logger usage Signed-off-by: Emad Habib <ehabib@slack-corp.com> * Update the usage test files and replace _ with - for the flag Signed-off-by: Emad Habib <ehabib@slack-corp.com> * Apply code review comments Signed-off-by: Emad Habib <ehabib@slack-corp.com> * Add copyrights and release notes Signed-off-by: Emad Habib <ehabib@slack-corp.com> * Update the year in the copyrights Signed-off-by: Emad Habib <ehabib@slack-corp.com> * Fix typo Signed-off-by: Emad Habib <ehabib@slack-corp.com> * Empty Commit Signed-off-by: Emad Habib <ehabib@slack-corp.com> Signed-off-by: Emad Habib <ehabib@slack-corp.com>
|
Thanks for the contribution! Before we can merge this, we need @EmadMokhtar to sign the Salesforce Inc. Contributor License Agreement. |
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
tanjinx
previously approved these changes
Mar 26, 2024
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
timvaillancourt
merged commit 453ee84
into
slack-vitess-r15.0.5
194 of 195 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR backports structured logging to v15 using the v16 PR: vitessio#11960. This backport is backported/required in our v14 release
Related Issue(s)
vitessio#11960
Checklist
Deployment Notes