Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vtgateproxy firstready balancer fail fast #362

Merged
merged 2 commits into from
May 21, 2024

Conversation

demmer
Copy link
Collaborator

@demmer demmer commented May 21, 2024

Description

Minor tweaks to fail fast

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

Copy link
Collaborator

@rjlaine rjlaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this should result in much more predictable behavior.

I'd like to do a second pass to handle all the unhandled errors, but that can be a separate PR.

@demmer demmer merged commit 3dee7ad into vtgateproxy May 21, 2024
152 of 241 checks passed
@demmer demmer deleted the vtgateproxy-firstready-balancer-fail-fast branch May 21, 2024 23:42
dedelala pushed a commit that referenced this pull request Jul 30, 2024
* return a custom error to fail fast

* fatal if the resolver cannot initialize

Signed-off-by: Esme Lamb <dlamb@slack-corp.com>
dedelala pushed a commit that referenced this pull request Nov 12, 2024
* return a custom error to fail fast

* fatal if the resolver cannot initialize

Signed-off-by: Esme Lamb <dlamb@slack-corp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants