Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack-15.0: update to v16 grpc/protobuf deps #388

Closed
wants to merge 9 commits into from
Closed

slack-15.0: update to v16 grpc/protobuf deps #388

wants to merge 9 commits into from

Conversation

timvaillancourt
Copy link
Member

@timvaillancourt timvaillancourt commented May 31, 2024 •
edited
Loading

Description

This PR moves us towards a newer protobuf/grpc library by moving to v16's protobuf/grpc dependencies

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@timvaillancourt
slack-15.0: update to v16 grpc/protobuf deps
12e16df 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@github-actions github-actions bot added this to the v15.0.5 milestone May 31, 2024
@timvaillancourt
make proto
d8f0092 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt timvaillancourt marked this pull request as ready for review May 31, 2024 20:32
@timvaillancourt timvaillancourt requested a review from a team as a code owner May 31, 2024 20:32
@github-actions github-actions bot added the Stale label Jul 11, 2024
@github-actions github-actions bot added the Stale label Aug 11, 2024
@slackhq slackhq deleted a comment from github-actions bot Aug 13, 2024
@slackhq slackhq deleted a comment from github-actions bot Aug 13, 2024
@github-actions GitHub Actions
Copy link

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

@github-actions github-actions bot added the Stale label Sep 12, 2024
@timvaillancourt timvaillancourt deleted the v16-gprc-protobuf-slack-15.0 branch October 10, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmogilev vmogilev vmogilev approved these changes

Assignees
No one assigned
Labels
v15 v16-backport
Projects
None yet
Milestone
v15.0.5
Development

Successfully merging this pull request may close these issues.
2 participants
@timvaillancourt @vmogilev