Backport upstream: do not demote a new primary after backup completion (#12856) #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* do not demote a new primary after backup completion Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com> * move set replication source out of vtctld and into tablet Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com> * remove set replication source in vtctld Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com> * fix ctx, and wip test Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com> * add e2e test instead of unit test Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com> * use built in methods Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com> * omit this in test Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com> * Update go/vt/vttablet/tabletmanager/rpc_backup.go Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Signed-off-by: Olga Shestopalova <olgash@mit.edu> Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com> * move wg done to top of func Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com> * fix method change Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com> Signed-off-by: <oshestopalova@hubspot.com> Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com> * try running this in isolation Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com> * try running this in isolation, dont run with others Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com> * add debug logging Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com> * add debug logging Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com> * Update go/test/endtoend/backup/vtctlbackup/backup_utils.go Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com> Signed-off-by: Olga Shestopalova <olgash@mit.edu> * Update go/test/endtoend/backup/vtctlbackup/backup_utils.go Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com> Signed-off-by: Olga Shestopalova <olgash@mit.edu> * run goimports Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com> * remove dupe Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com> * remove generated file Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com> --------- Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com> Signed-off-by: Olga Shestopalova <olgash@mit.edu> Signed-off-by: <oshestopalova@hubspot.com> Co-authored-by: Olga Shestopalova <oshestopalova@hubspot.com> Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com>
|
Thanks for the contribution! Before we can merge this, we need @olyazavr to sign the Salesforce Inc. Contributor License Agreement. |
vmogilev
previously approved these changes
Jun 25, 2024
|
just realized later, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do not demote a new primary after backup completion
move set replication source out of vtctld and into tablet
remove set replication source in vtctld
fix ctx, and wip test
add e2e test instead of unit test
use built in methods
omit this in test
Update go/vt/vttablet/tabletmanager/rpc_backup.go
move wg done to top of func
fix method change
try running this in isolation
try running this in isolation, dont run with others
add debug logging
add debug logging
Update go/test/endtoend/backup/vtctlbackup/backup_utils.go
Update go/test/endtoend/backup/vtctlbackup/backup_utils.go
run goimports
remove dupe
remove generated file
Description
backport vitessio#12856
Related Issue(s)
Checklist
Deployment Notes