vtgate tablet balancer #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Demmer <mdemmer@slack-corp.com>
Signed-off-by: Michael Demmer <mdemmer@slack-corp.com>
Signed-off-by: Venkatraju V <venkatraju@slack-corp.com>
Signed-off-by: Venkatraju V <venkatraju@slack-corp.com>
|
Tests in dev: https://slack-pde.slack.com/archives/C03P78B4M98/p1718738270862309 Verified in prod: https://slack-pde.slack.com/archives/C03P78B4M98/p1718838142745699 |
Signed-off-by: Venkatraju V <venkatraju@slack-corp.com>
…itess into v14_vtgate_balancer_v2 Signed-off-by: Venkatraju V <venkatraju@slack-corp.com>
| @@ -1,6 +1,9 @@ | |||
| Usage of vtgate: | |||
| --allowed_tablet_types TabletTypeList Specifies the tablet types this vtgate is allowed to route queries to | |||
| --alsologtostderr log to standard error as well as files | |||
| --balancer_enabled Whether to enable the tablet balancer to evenly spread query load | |||
There was a problem hiding this comment.
Note for later: "balancer" feels pretty vague to me (there are several concepts of "balancing" in Vitess)
There was a problem hiding this comment.
Good point. I could change this to tabletbalancer_* although it is longer than I like. Or maybe wait for suggestions when this is upstreamed and make a PR to sync with that?
timvaillancourt
approved these changes
Jun 28, 2024
venkatraju
added a commit
that referenced
this pull request
Jun 28, 2024
implement flow based tablet load balancer Signed-off-by: Michael Demmer <mdemmer@slack-corp.com> Signed-off-by: Venkatraju V <venkatraju@slack-corp.com> Co-authored-by: Michael Demmer <mdemmer@slack-corp.com>
tanjinx
pushed a commit
that referenced
this pull request
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the tabletbalancer prototype from #308 with a couple of changes: