Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack-19.0: add structured logging #449

Merged
merged 9 commits into from
Jul 10, 2024
Merged

slack-19.0: add structured logging #449

merged 9 commits into from
Jul 10, 2024

Conversation

timvaillancourt
Copy link
Member

Description

This PR is the not-yet-upstreamed vitessio#13061 with the review suggestions from the comments applied

Related Issue(s)

vitessio#13061

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

EmadMokhtar and others added 6 commits July 10, 2024 01:30
@EmadMokhtar @timvaillancourt
Install zap log and noglog
f345ace 
Signed-off-by: Emad Habib <ehabib@slack-corp.com>
@EmadMokhtar @timvaillancourt
Implement the Vitess Structure Logger VTSLoger
03a7cfe 
Signed-off-by: Emad Habib <ehabib@slack-corp.com>
@EmadMokhtar @timvaillancourt
Move the structure logging code to logger.go file
fbb19d3
@timvaillancourt
make PR suggestions from vitessio#13061
15b723a 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt
Fix bad merge conflict
27bbbff 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt
Fix bad merge conflict again
ac21a9a 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@salesforce-cla Salesforce CLA
Copy link

salesforce-cla bot commented Jul 9, 2024

Thanks for the contribution! Before we can merge this, we need @EmadMokhtar to sign the Salesforce Inc. Contributor License Agreement.

@timvaillancourt timvaillancourt changed the title slack-19.0 add structured logging slack-19.0: add structured logging Jul 9, 2024
@github-actions github-actions bot added this to the v19.0.4 milestone Jul 9, 2024
@timvaillancourt timvaillancourt marked this pull request as ready for review July 10, 2024 00:05
@timvaillancourt timvaillancourt requested a review from a team as a code owner July 10, 2024 00:05
@timvaillancourt
fix test
7009b2d 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt
add flags e2e test for vtgateclienttest
831a858 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt
update error msg
8d14c01 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt timvaillancourt merged commit f1ff852 into slack-19.0 Jul 10, 2024
158 of 163 checks passed
@timvaillancourt timvaillancourt deleted the structured-logger_slack-19.0 branch July 10, 2024 11:56
@timvaillancourt timvaillancourt modified the milestones: v19.0.4, v19.0.5 Sep 10, 2024
@timvaillancourt timvaillancourt mentioned this pull request Oct 12, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla:missing custom-patch upstream-me v19
Projects
None yet
Milestone
v19.0.5
Development

Successfully merging this pull request may close these issues.
2 participants
@timvaillancourt @EmadMokhtar