slack-15.0: support v17+ --queryserver-config-* duration values
#492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dsFloatFlag_slack-15.0 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
timvaillancourt
changed the title
slack-15.0: support v19-style timeout valuesslack-15.0: support v19-style --queryserver-config-*-timeout values
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
timvaillancourt
changed the title
slack-15.0: support v19-style --queryserver-config-*-timeout valuesslack-15.0: support v17+ --queryserver-config-*-timeout flag values
timvaillancourt
changed the title
slack-15.0: support v17+ --queryserver-config-*-timeout flag valuesslack-15.0: support v17+ --queryserver-config-* duration values
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
* fakesqldb: Guard query log usage with lock This lock is used around adding to the query log, but it means we also need to use the lock when reading from it or when resetting it. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * grpcvtctldserver: Fix alias for loop reuse Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * unit_race: Increase runtime We've been adding a lot of tests for the evalengine and we're bumping up to the timeout. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> --------- Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
|
Thanks for the contribution! Before we can merge this, we need @dbussink to sign the Salesforce Inc. Contributor License Agreement. |
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
tanjinx
approved these changes
Aug 20, 2024
makinje16
pushed a commit
that referenced
this pull request
Aug 28, 2024
…492) * WIP Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * update all flags Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * update e2e flag test Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * 2 missing flags Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * rename Type() Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * empty commit to test ci Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fakesqldb: Guard query log usage with lock (vitessio#12813) * fakesqldb: Guard query log usage with lock This lock is used around adding to the query log, but it means we also need to use the lock when reading from it or when resetting it. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * grpcvtctldserver: Fix alias for loop reuse Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * unit_race: Increase runtime We've been adding a lot of tests for the evalengine and we're bumping up to the timeout. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> --------- Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * remove t.Parallel() like upstream did Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for v19-style timeout values to make the rollout of v19 easier. Feature flagging this by Vitess version and chef at the same time is too complicated. TL;DR: v17+ expects real time durations, not a number
This change in flag style is explained in these v17 changelog notes
The new
DurationOrSecondsFloatFlagstores a timeout value in the samefloat64format but supports parsing string durations (the v19 behaviour) AND floats (the v15 behaviour)Finally, vitessio#12813 was cherry-picked to resolve some CI flakiness preventing this PR from passing CI
Related Issue(s)
Potential CI flake fix: vitessio#12813
Checklist
Deployment Notes