Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip warmup time on e2e tests #563

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

dedelala
Copy link

connection warmup time is causing e2e tests to fail because we only wait until the discovery file is parsed not until the connection pool has settled - this is the easiest fix for now, tested e2e tests on a beach

this is just going onto the v15 branch which we're not using yet - I'll be running a branch build of this to try it out on dev loadtest as soon as I get a chance

Signed-off-by: Esme Lamb <dlamb@slack-corp.com>
@dedelala dedelala requested a review from a team as a code owner November 21, 2024 00:32
@github-actions github-actions bot added this to the v15.0.5 milestone Nov 21, 2024
Copy link
Collaborator

@rjlaine rjlaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@dedelala dedelala merged commit 0b70c76 into vtgateproxy-15 Dec 9, 2024
189 of 195 checks passed
@dedelala dedelala deleted the vtgateproxy-15-e2e branch December 9, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants