Fix event plot curve creation #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failures look to be due to this change: pytest-dev/pytest-qt#515 Just need to update our conftest file to not pass the program name through |
…lication when running tests otherwise it will misinterpret it as a ui file name which it will then fail to load
…cated and now removed warns() usage in pytest 8.0
YektaY
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just adds the second '*' to the keyword arguments so they are handled properly. Added simple test case to cover this, as well as an example event plot that can be run.
Also includes a couple minor test updates to make the test suite compatible with pytest 8.0 and pytest-qt 4.3+
To reproduce can run the new test or example without the change to
eventplot.pyand see it fail