Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Cloudfront Alternate Domain Names #79

Closed
pinarruiz opened this issue Feb 24, 2023 · 2 comments
Closed

Support for Cloudfront Alternate Domain Names #79

pinarruiz opened this issue Feb 24, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@pinarruiz
Copy link

Adding an option like --alternateDomainNames where domain names will be fed in a comma separated manner, or reading multiple entries of the option.

As far as i know there is no way of doing this.
@sladg sladg added the enhancement New feature or request label Feb 24, 2023
@sladg
Copy link
Owner

sladg commented Feb 24, 2023

Good point, currently it's possible only with extending CDK and altering the stack definition manually.
Will take a look at it, should be done within few days.

sladg added a commit that referenced this issue Feb 26, 2023
@sladg
✨ feat(domains): rework how domains are passed, allow for many, auto-…
e74a212 
…guess zone (#73, #79)

Allow for passing multiple domains. Get domains from CLI, automatically select the most fitting one.

BREAKING CHANGE: Changed CLI interface, different way to pass domains

#73, #79
@sladg
Copy link
Owner

sladg commented Feb 26, 2023

This has been released in version 7.0.0.
Use --domainNames example.com,other.domain.com,extra.net in CLI command.

@sladg sladg closed this as completed Feb 26, 2023
@pinarruiz pinarruiz mentioned this issue Feb 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sladg @pinarruiz