Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: #392 kotlin language linter support #444

Merged
merged 1 commit into from
Feb 15, 2024
Merged

feat: #392 kotlin language linter support #444

merged 1 commit into from
Feb 15, 2024

Conversation

isaac-heist-slalom
Copy link
Contributor

secureli-392

Add linting support for Kotlin

Changes

  • Implemented ktlint in addition to detekt for Kotlin repos

Testing

  • All existing unit tests are passing

Clean Code Checklist

  • Meets acceptance criteria for issue
  • New logic is covered with automated tests
  • Appropriate exception handling added
  • Thoughtful logging included
  • Documentation is updated
  • Follow-up work is documented in TODOs
  • TODOs have a ticket associated with them
  • No commented-out code included

@isaac-heist-slalom isaac-heist-slalom marked this pull request as ready for review February 14, 2024 21:36
@isaac-heist-slalom isaac-heist-slalom merged commit 0ac7008 into main Feb 15, 2024
6 checks passed
@isaac-heist-slalom isaac-heist-slalom deleted the feature/secureli-392-add-linting-support-for-kotlin branch February 15, 2024 22:57
@JordoHeffernan JordoHeffernan mentioned this pull request Mar 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordoHeffernan JordoHeffernan JordoHeffernan approved these changes

@tdurk93 tdurk93 Awaiting requested review from tdurk93

@kevin-orlando kevin-orlando Awaiting requested review from kevin-orlando

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isaac-heist-slalom @JordoHeffernan