Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend full URI to issues instead of just the number #19

Closed
underyx opened this issue Jun 19, 2017 · 6 comments
Closed

Recommend full URI to issues instead of just the number #19

underyx opened this issue Jun 19, 2017 · 6 comments
Assignees

Comments

@underyx
Copy link

underyx commented Jun 19, 2017

We always copy paste the entire URL to the issue in the last line instead of just #123.

  1. This makes it easy to open the issue when you're browsing the repo somewhere other than your issue tracker — I could just cmd-click on Fixes https://github.com/slashsBin/styleguide-git-commit-message/issues/1 in the terminal while reading the git log.
  2. It allows you to migrate to a new issue tracker (such as github to gitlab) without any confusion.
@underyx
Copy link
Author

underyx commented Aug 21, 2017

@slashsbin not interested in this change?

@slashsbin
Copy link
Owner

hi
I'm sorry for the delay, I was super busy with a new product launch.

Actually, I don't totally agree with you, although I agree that doing so will improve terminal log viewing.

Personally, for me, it's an overkill to paste the full URL because I need to copy/paste it from somewhere else beforehand.

Another thing is, doing so may break automatcally closing issues using keywords.

Maybe we should simplify browsing issues by other means like:

What do you think?

@slashsbin slashsbin self-assigned this Aug 23, 2017
@slashsbin
Copy link
Owner

It seems like GitLab is OK with automatic closing of issues by full URL.

@underyx
Copy link
Author

underyx commented Aug 23, 2017 via email

@slashsbin
Copy link
Owner

hi
please check rule#4.
any suggestions?

@underyx
Copy link
Author

underyx commented Sep 2, 2017

Perfect, we can consider this issue closed, thank you!

@underyx underyx closed this as completed Sep 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants