Allow optional variable to use inventory_hostname instead of ansible_hostname #38
Conversation
|
Partially addresses #27 |
|
Fixed up the README linting issues reported using force push |
ObjectiveTruth
force-pushed
the
master
branch
4 times, most recently
from
c888228 to
d208ab6
Compare
|
I enabled the linter on my fork, so the new forced push updates should pass all the tests this time 👍 |
|
Can this be merged, @sleighzy? |
Hi @ObjectiveTruth . I've dropped a couple of comments on this now, and a request for slightly renaming the variables. I'll merge it in once you push the changes. Thanks heaps by the way, much appreciated for the efforts and updates. Will be very helpful given this problem has come up before. |
ObjectiveTruth
force-pushed
the
master
branch
2 times, most recently
from
a04b3fb to
3187380
Compare
…r_use_servers_inventory_hostname * This will be explained in the next commit * Added default param to false
|
I've applied the updates and you're right the tests were failing because I missed the variable name change in the |
|
Thanks @ObjectiveTruth , all sorted now, cheers for the contribution. |
No problem! Glad i could help 👍 |
This PR includes a README to explain the issue that I encountered with this role.
I've dded an optional parameter(that defaults to false to preserve current behaviour) where the hostname used in the server list is used. This happens when the the host only gives its hostname instead of its FQDN(Fully Qualified Domain Name). This can cause the server being unable to see each other.
Also, this could be required if you want/need to use TLS since the hostname needs to match the certificate it presents