-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve README with ftdetect gotcha #62
Conversation
Copied logic from vim-coffee, so all creds for actual work goes there ;)
Interesting to note that we had |
Instead of brute forcing filetype, I think we should just inform users of the issue and how to fix it. |
ed2c097
to
52a015d
Compare
And possible ways to fix that
@ixti I definitely think this is an improvement. It's kind of a strange use case that has you scratching your head, so documenting it is definitely nice for user's that hit it. |
Known Issues | ||
------------ | ||
|
||
We use `setfiletype` upon autodetect, which does not overrides filetype once it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you mean which overrides previous values
instead of which does not overrides
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set fieltype
does override. setf
does not.
@rapind although I understand your point of view (and I'm actually gonna use And personally I think that any plugin should do as little as possible by default. So that user would configure/enable necessary behavior himself as he needs. |
I've also changed it locally. I just think it'll impact more people by being unobtrusive, and I haven't been able to think of a scenario where being obtrusive would impact anyone (why would they assign something else to .slim?). I'm happy enough with a mention in the readme though. We've probably discussed it to death at this point :) |
@rapind I can't recall at the moment but I remember I saw couple of absolutely different projects using same filename extensions for their files. |
@minad Please merge this, if you have no objections. |
This PR does not changes current behavior, but adds README description of it and how to change to be more "enforced". |
@minad I'm not proficient in VimL to call myself a good candidate to be a maintainer, but I'm definitely will be happy to help. In any case, this particular change is not adding changes to the vim script itself ;)) it's adding explanation to the README why current version does not work in a very specific situation as one might expect, and how to avoid this. |
@minad I've literally never even touched VimL. At most just tweaked my own configs. I don't even get a chance to use slim much these days either :( |
Closing this due to no activity (I assume no interest as well) from maintainers side. |
@ixti As I wrote above, there is a need of someone maintaining this. Even if the maintainers are not very proficient in Viml, they could still take care that the PRs get tested and merged... |
And possible ways to fix that See: #62
See: