Fixes PHPStan errors until level 4

.travis.yml

@@ -14,11 +14,12 @@ matrix:
   - php: nightly
 
 before_script:
-- composer require php-coveralls/php-coveralls:^2.1.0
+- composer require php-coveralls/php-coveralls:^2.2.0
 - composer install -n
 
 script:
 - if [[ "$ANALYSIS" == 'true' ]]; then vendor/bin/phpunit --coverage-clover clover.xml ; fi
+- if [[ "$ANALYSIS" == 'true' ]]; then vendor/bin/phpstan analyse src ; fi
 
 after_success:
 - if [[ "$ANALYSIS" == 'true' ]]; then vendor/bin/php-coveralls --coverage_clover=clover.xml -v ; fi

composer.json

@@ -30,6 +30,7 @@
         "slim/slim": "^4.5"
     },
     "require-dev": {
+        "phpstan/phpstan": "^0.12.23",
         "phpunit/phpunit": "^8.5"
     },
     "config": {

phpstan.neon

@@ -0,0 +1,4 @@
+parameters:
+  level: 4
+includes:
+    - vendor/jangregor/phpstan-prophecy/src/extension.neon

src/Application/Handlers/HttpErrorHandler.php

@@ -52,7 +52,7 @@ protected function respond(): Response
 
         if (
             !($exception instanceof HttpException)
-            && ($exception instanceof Exception || $exception instanceof Throwable)
+            && $exception instanceof Throwable
             && $this->displayErrorDetails
         ) {
             $error->setDescription($exception->getMessage());

src/Application/Handlers/ShutdownHandler.php

@@ -28,7 +28,7 @@ class ShutdownHandler
      * ShutdownHandler constructor.
      *
      * @param Request       $request
-     * @param $errorHandler $errorHandler
+     * @param HttpErrorHandler $errorHandler
      * @param bool          $displayErrorDetails
      */
     public function __construct(

tests/Domain/User/UserTest.php

@@ -21,12 +21,12 @@ public function userProvider()
 
     /**
      * @dataProvider userProvider
-     * @param $id
-     * @param $username
-     * @param $firstName
-     * @param $lastName
+     * @param int $id
+     * @param string $username
+     * @param string $firstName
+     * @param string $lastName
      */
-    public function testGetters($id, $username, $firstName, $lastName)
+    public function testGetters(int $id, string $username, string $firstName, string $lastName)
     {
         $user = new User($id, $username, $firstName, $lastName);
 
@@ -38,12 +38,12 @@ public function testGetters($id, $username, $firstName, $lastName)
 
     /**
      * @dataProvider userProvider
-     * @param $id
-     * @param $username
-     * @param $firstName
-     * @param $lastName
+     * @param int $id
+     * @param string $username
+     * @param string $firstName
+     * @param string $lastName
      */
-    public function testJsonSerialize($id, $username, $firstName, $lastName)
+    public function testJsonSerialize(int $id, string $username, string $firstName, string $lastName)
     {
         $user = new User($id, $username, $firstName, $lastName);