Merge branch 'l0gicgate/4.x-RouteInvocationStrategySetter' into 4.x

Closes #2634
slimphp · Apr 20, 2019 · 341e1bd · 341e1bd
2 parents 6aa3c6c + 2cf746c
commit 341e1bd
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@
 ## 4.0.0 - TBD
 
 ### Added
+- [#2634](https://github.com/slimphp/Slim/pull/2634) Added ability to set invocation strategy on a per-route basis.
 - [#2555](https://github.com/slimphp/Slim/pull/2555) Added PSR-15 Middleware Support
 - [#2529](https://github.com/slimphp/Slim/pull/2529) Slim no longer ships with a PSR-7 implementation. You need to provide a PSR-7 ServerRequest and a PSR-17 ResponseFactory to run Slim.
 - [#2507](https://github.com/slimphp/Slim/pull/2507) Method names are now case-sensitive in Router::map(), and so, by extension, in App::map() 

diff --git a/Slim/Interfaces/RouteInterface.php b/Slim/Interfaces/RouteInterface.php
@@ -22,6 +22,14 @@ interface RouteInterface
      */
     public function getInvocationStrategy(): InvocationStrategyInterface;
 
+    /**
+     * Set route invocation strategy
+     *
+     * @param InvocationStrategyInterface $invocationStrategy
+     * @return RouteInterface
+     */
+    public function setInvocationStrategy(InvocationStrategyInterface $invocationStrategy): RouteInterface;
+
     /**
      * Get route methods
      *

diff --git a/Slim/Routing/Route.php b/Slim/Routing/Route.php
@@ -165,6 +165,15 @@ public function getInvocationStrategy(): InvocationStrategyInterface
         return $this->invocationStrategy;
     }
 
+    /**
+     * {@inheritdoc}
+     */
+    public function setInvocationStrategy(InvocationStrategyInterface $invocationStrategy): RouteInterface
+    {
+        $this->invocationStrategy = $invocationStrategy;
+        return $this;
+    }
+
     /**
      * {@inheritdoc}
      */

diff --git a/tests/Routing/RouteTest.php b/tests/Routing/RouteTest.php
@@ -121,6 +121,22 @@ public function testGetInvocationStrategy()
         $this->assertEquals($strategy, $route->getInvocationStrategy());
     }
 
+    public function testSetInvocationStrategy()
+    {
+        $callable = function (ServerRequestInterface $request, ResponseInterface $response, $args) {
+            return $response;
+        };
+
+        $responseFactory = $this->getResponseFactory();
+        $callableResolver = new CallableResolver();
+        $strategy = new RequestResponse();
+
+        $route = new Route(['GET'], '/', $callable, $responseFactory, $callableResolver);
+        $route->setInvocationStrategy($strategy);
+
+        $this->assertSame($strategy, $route->getInvocationStrategy());
+    }
+
     public function testGetGroups()
     {
         $callable = function (ServerRequestInterface $request, ResponseInterface $response, $args) {