Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract setting content-length to middleware #2043

Closed
codeguy opened this issue Nov 19, 2016 · 3 comments
Closed

Extract setting content-length to middleware #2043

codeguy opened this issue Nov 19, 2016 · 3 comments
Labels
Slim 4
Milestone
4.0.0-alpha

Comments

@codeguy
Copy link
Member

codeguy commented Nov 19, 2016

Current implementation conflicts with New Relic. Make this an optional middleware.
@codeguy codeguy added the Slim 4 label Nov 19, 2016
@codeguy codeguy added this to the 4.0 milestone Nov 19, 2016
@codeguy
Copy link
Member Author

codeguy commented Dec 4, 2016

@akrabat Was this for the inbound request object or outbound response or both?

@akrabat
Copy link
Member

akrabat commented Dec 5, 2016

Outbound. See https://github.com/slimphp/Slim/blob/3.x/Slim/App.php#L543-L553

@Zegnat Zegnat mentioned this issue Mar 7, 2017
Closed
@geggleto geggleto modified the milestone: 4.0 Mar 19, 2017
@akrabat
Copy link
Member

akrabat commented Aug 13, 2017

Fixed by #2254.

akrabat added a commit that referenced this issue Aug 17, 2017
@akrabat
Merge branch 'content-length-middleware' into 4.x
2cac1ac 
Closes #2254
Fixes #2043
@akrabat akrabat closed this as completed May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Slim 4
Projects
None yet
Milestone
4.0.0-alpha
Development

No branches or pull requests
3 participants
@codeguy @akrabat @geggleto