Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove traits if possible, simplify stack trace #2053

Closed
codeguy opened this issue Nov 19, 2016 · 7 comments
Closed

Remove traits if possible, simplify stack trace #2053

codeguy opened this issue Nov 19, 2016 · 7 comments

Comments

@codeguy
Copy link
Member

codeguy commented Nov 19, 2016

Will require more investigation.

@codeguy codeguy added the Slim 4 label Nov 19, 2016
@codeguy codeguy added this to the 4.0 milestone Nov 19, 2016
@geggleto
Copy link
Member

I floated the idea of removing Callable Resolver to it's own repo. Ideally it can be provided as a static or singleton class inside the DIC. There really isnt a reason for it being a trait.

Moving it to it's own class should stop some of the jumping across the files.

@codeguy
Copy link
Member Author

codeguy commented Nov 20, 2016

@geggleto I wasn't paying much attention to Slim when this was added, so I'm not 100% familiar with the internals of the current implementation. Can you walk me through it sometime soon on Slack?

@geggleto
Copy link
Member

@codeguy Yeah, just ping me when you want to go through it.

@geggleto geggleto modified the milestone: 4.0 Mar 19, 2017
@akrabat
Copy link
Member

akrabat commented Sep 16, 2018

Maybe the trait should become a class and be composed into App and Route?

@akrabat akrabat removed this from the 4.0 milestone Sep 16, 2018
@mathmarques
Copy link
Contributor

I think that a class MiddlewareAware composed into App and Route would be better than extends an abstract class.
If you want, I can make this change.

@akrabat
Copy link
Member

akrabat commented Oct 5, 2018

If you want, I can make this change.

Yes. This probably affects into the PSR-15 support that @bnf has started.

akrabat added a commit that referenced this issue Feb 22, 2019
@l0gicgate
Copy link
Member

Closed as per #2555

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants