-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Suite Proposed Changes #2585
Comments
Pimple should be mocked out for 4.x testing. |
Agreed re PHPUnit upgrade. |
Okay and what about the code coverage bit @akrabat? This is more so just for developer user experience, it's annoying when I start a new branch I have to update .gitignore every time, I do generate coverage locally to make sure I've done all the required tests. At the minimum we should at least add a predefined coverage-html output directory to .gitignore |
I like the idea to remove the pimple dev dependency by mocking Now, when comparing MockBuilder and Prophecy mocks, I'd propose to go with Prophecy for four reasons:
I've prepared a pull request in #2602 to demonstrate how that change would look like when using Prophecy. |
I have more exprience with |
We need to tidy up our test suite for Slim 4. I would like to propose the following:
Add pre-defined code coverage directory in phpunit.xml.dist
We should add coverage-html generation in our phpunit configuration and also add that pre-defined directory to our .gitignore
Get rid of Pimple as a Dev Dependency
All we need for our test suite is a simple implementation of
ContainerInterface
, we don't to anything but simple key/value setting. Less dependencies to install means faster builds. Plus the Pimple instantiation/synthax is terrible:We need to update PHPUnit to 7.5 and remove deprecated methods
Currently we are using
TestCase::assertAttributeEquals
a lot which is a deprecated method. Will need to refactor all tests using deprecated methods from this listBreak up AppTest into smaller modules
This may take some time, but I want to make
App
a little bit more modular in the near future which will hopefully reduce the size of theAppTest
. A lot of the test cases are from proxyingRouter
methods.Status
The text was updated successfully, but these errors were encountered: