4.x Remove Pimple #2587
4.x Remove Pimple #2587
Conversation
l0gicgate
force-pushed
the
4.x-RemovePimple
branch
from
312dfe4
to
b1cb7c7
Compare
| @@ -39,8 +37,7 @@ public static function setupBeforeClass() | |||
|
|
|||
| public function testGetContainer() | |||
| { | |||
| $pimple = new Pimple(); | |||
| $container = new Psr11Container($pimple); | |||
| $container = new MockContainer(); | |||
There was a problem hiding this comment.
Why have a MockContainer object when we could be using PHPUnit's createMock() ?
There was a problem hiding this comment.
We need to have ArrayAccess implemented on the class unless you want to force usage of the ContainerInterface::set() method
There was a problem hiding this comment.
We need to have ArrayAccess implemented on the class
Why? Slim doesn't set anything into the container anymore does it?
There was a problem hiding this comment.
I misread your question. We can mock a container for that specific test sure. We have a MockContainer though so why not use it
There was a problem hiding this comment.
Why do we have a MockContainer though? We shouldn't need it as we should be able to use PHPUnit's Mocking functionality for every situation where Slim's classes use a container. If we can't then we need to look at that particular Slim code.
|
Will refactor with Mocks instead and re-open. |
Removing Pimple as per discussion in #2585.