Add a redirect route shortcut #2425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akrabat
requested changes
Apr 14, 2018
There was a problem hiding this comment.
Thanks @ellotheth!
Please add a test that ensures that UriInterface as $destination also works.
This is correct. You should only change the response object on the way back anyway. |
|
@akrabat Righto, done! |
|
Can you also do this against the |
|
Yup, and I'll add the docs. Should be be done by tomorrow night. |
ellotheth
force-pushed
the
redirect-route
branch
from
8d75908
to
5a321f2
Compare
This was referenced Apr 17, 2018
akrabat
approved these changes
Apr 19, 2018
akrabat
added a commit
that referenced
this pull request
Apr 19, 2018
akrabat
added a commit
that referenced
this pull request
Apr 19, 2018
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per a short conversation with @akrabat.
(I'm blanket overwriting whatever status code the
ResponseInterfacehas because I wasn't sure the flexibility in e.g.Slim\Http\Response::withRedirectis necessary at this level, but maybe it's worth keeping the behavior the same for consistency?)