Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace header when sending first one of each header (for 4.x) #2495

Merged
merged 1 commit into from
Sep 2, 2018
Merged

Replace header when sending first one of each header (for 4.x) #2495

merged 1 commit into from
Sep 2, 2018

Conversation

akrabat
Copy link
Member

@akrabat akrabat commented Sep 2, 2018

Forward port #2441 to 4.x:

When we call header() to send the headers in the Response, set the replace parameter to true for the first of that header name and then set it to false.

Don't do this if the header is Set-Cookie so we don't break sessions.

Fixes #2282
Fixes #2246

@akrabat akrabat changed the base branch from 3.x to 4.x September 2, 2018 13:36
@coveralls
Copy link

coveralls commented Sep 2, 2018

Coverage Status

Coverage increased (+1.3%) to 97.799% when pulling ed6a18f on akrabat:override-previously-set-headers-4.x into 6ec52e3 on slimphp:4.x.

When we call `header()` to send the headers in the Response, set the
`replace` parameter to true for the first of that header name and then
set it to false.

Don't do this if the header is Set-Cookie so we don't break sessions.

Fixes #2282
Fixes #2246
@akrabat akrabat merged commit ed6a18f into slimphp:4.x Sep 2, 2018
@akrabat akrabat added this to the 4.0 milestone Sep 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants