Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop DiscordBee from sending a presence update if not connected to Discord #84

Merged
merged 1 commit into from
Aug 29, 2021

Conversation

Svarr
Copy link
Contributor

@Svarr Svarr commented Aug 29, 2021

Fixes #81 (Rich Presence ghosting in Discord) by tracking the connection state to Discord in DiscordBee and preventing it from sending presence updates while Discord is not running.

@sll552
Copy link
Owner

sll552 commented Aug 29, 2021

Squash the commits pls

@Svarr
Copy link
Contributor Author

Svarr commented Aug 29, 2021

How do I do that?

I could merge this branch into the fork's master and squash the commits this way...?

DiscordBee.cs Show resolved Hide resolved
@sll552
Copy link
Owner

sll552 commented Aug 29, 2021

How do I do that?

I could merge this branch into the fork's master and squash the commits this way...?

just do an interactive rebase and fixup/squash the commits into one

@Svarr
Copy link
Contributor Author

Svarr commented Aug 29, 2021

That just added the commits on top of the old ones...

@sll552
Copy link
Owner

sll552 commented Aug 29, 2021

That just added the commits on top of the old ones...

What git tool are you using? for commandline it would be something like git rebase -i upstream/master and then vim should open and you can select what happens to each commit (there you would do fixup or squash instead of pick).

For tortoisegit you would select rebase and in the window top right select upstream/master and tick the force checkbox, then the commits will be listed and you can pick/squash.

Anyway I guess i can do it myself.

@Svarr
Copy link
Contributor Author

Svarr commented Aug 29, 2021

What git tool are you using? for commandline it would be something like git rebase -i upstream/master and then vim should open and you can select what happens to each commit (there you would do fixup or squash instead of pick).

For tortoisegit you would select rebase and in the window top right select upstream/master and tick the force checkbox, then the commits will be listed and you can pick/squash.

I use Git Extensions and GitLab. Usually I do these things directly on GitLab but GitHub seems to lack most of the functionalities.

Anyway I guess i can do it myself.

That would be great. 😄

@sll552
Copy link
Owner

sll552 commented Aug 29, 2021

I use Git Extensions and GitLab. Usually I do these things directly on GitLab but GitHub seems to lack most of the functionalities.

Well unfortunately these online tools mostly miss those "advanced" git usecases.

Anyway I guess i can do it myself.

That would be great. 😄

Done

@sll552 sll552 merged commit 348e91a into sll552:master Aug 29, 2021
@Svarr Svarr deleted the feature/lifecycle-fix branch August 29, 2021 15:18
@sll552 sll552 changed the title Pull and merge feature/lifecycle-fix into master Stop DiscordBee from sending a presence update if not connected to Discord Aug 29, 2021
@sll552 sll552 added the bugfix Fixes a bug label Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting UpdatePresenceWhenStopped is ignored and Presence shows impossible times
2 participants