Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update some CSS defaults for Overwatch 2 #180

Merged
merged 2 commits into from
Apr 17, 2023
Merged

Update some CSS defaults for Overwatch 2 #180

merged 2 commits into from
Apr 17, 2023

Conversation

zusorio
Copy link
Collaborator

@zusorio zusorio commented Mar 9, 2023 •
edited by slmnio
Loading

We already used these styles in all our new broadcasts by manually specifying them, this removes the need to do that every time.

Closes #170

@zusorio
Copy link
Collaborator Author

zusorio commented Mar 9, 2023

Also this closes #170

@slmnio
Copy link
Owner

slmnio commented Apr 17, 2023

Here's the basics of what it looks like now without custom broadcast CSS.

image

I added a tiny variant of the middle text when the broadcast has a broadcast margin of 0.0:

image

slmnio
slmnio approved these changes Apr 17, 2023
View reviewed changes
Copy link
Owner

@slmnio slmnio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we are all good to go with this

@slmnio slmnio merged commit a4904d3 into slmnio:master Apr 17, 2023
@zusorio zusorio deleted the update-ow2-defaults branch May 10, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slmnio slmnio slmnio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Overwatch 2 by default
2 participants
@zusorio @slmnio