Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn in local development when using non-local data server #196

Merged
merged 2 commits into from
Jul 16, 2023

Conversation

zusorio
Copy link
Collaborator

@zusorio zusorio commented Jul 16, 2023

Sometimes it's useful to run the SLMN.gg frontend with the production data server instead of spinning up a local one.
However, this can lead to a lot of confusion when you don't notice you're on the wrong data server and your changes aren't showing up.
This PR adds a banner during local development when the data server is not running on localhost/127.0.0.1.
image

@slmnio slmnio merged commit 48032c5 into slmnio:master Jul 16, 2023
@zusorio zusorio deleted the local-dev-wrong-dataserver-warning branch July 16, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants