-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Make clippy warnings trigger warnings instead of failures #338
Comments
Techcable
added a commit
to Techcable/slog
that referenced
this issue
Sep 23, 2024
Makes clippy warnings trigger warnings instead of hard errors, fixing issue slog-rs#338
Techcable
added a commit
to Techcable/slog
that referenced
this issue
Sep 23, 2024
Makes clippy warnings trigger warnings instead of hard errors, fixing issue slog-rs#338 HACK: Use my fork of auguwu/clippy-action to support "features" input.
Techcable
added a commit
to Techcable/slog
that referenced
this issue
Sep 23, 2024
Makes clippy warnings trigger warnings instead of hard errors, fixing issue slog-rs#338 HACK: Use my fork of auguwu/clippy-action to support "features" input.
Techcable
added a commit
to Techcable/slog
that referenced
this issue
Sep 23, 2024
Makes clippy warnings trigger warnings instead of hard errors, fixing issue slog-rs#338 HACK: Use my fork of auguwu/clippy-action to support "features" input.
Techcable
added a commit
to Techcable/slog
that referenced
this issue
Sep 23, 2024
Makes clippy warnings trigger warnings instead of hard errors, fixing issue slog-rs#338 HACK: Use my fork of auguwu/clippy-action to support "features" input.
1 task
This would be fixed by #339 but seems to have some downsides. |
I realized that since we only fail on the "hardcoded recent version" triggering hard errors shouldn't happen unexpectedly due to clippy changes. The only reason my changes triggered |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For example, while working on PR #337 I triggered the clippy lint
#[warn(clippy::std-instead-of-alloc)]
CI error log
Ideally this would have triggered a github actions
"warnings::"
annotation instead of a hard failure.This would still flag the issue without completely failing the build.
The text was updated successfully, but these errors were encountered: