Change RecordLocation members lifetime - log 0.4 support #171
Conversation
The file, function, module str lifetimes was changed to not require 'static lifetimes. (As log 0.4 introduced for better interoperability).
|
This is a part of work connected with: |
|
I will require some guidance on how to manage Cargo files for such distributed change. |
| @@ -52,3 +52,6 @@ slog-async = "2" | |||
|
|
|||
| [package.metadata.docs.rs] | |||
| features = ["std", "nested-values", "dynamic-keys"] | |||
|
|
|||
| [patch.crates-io] | |||
There was a problem hiding this comment.
This will have to go if this is to be landed.
There was a problem hiding this comment.
Sure, I know, just wanted to make whole code build.
| @@ -2265,17 +2265,17 @@ fn level_from_str() { | |||
| // {{{ Record | |||
| #[doc(hidden)] | |||
| #[derive(Clone, Copy)] | |||
| pub struct RecordLocation { | |||
| pub struct RecordLocation<'a> { | |||
There was a problem hiding this comment.
Well, this is going to be a breaking change. :/
|
I really appreciate your time. I guess there is no way around the fact that this is a breaking change. I guess it will have to be slog 3.x.y . And if we are to do v3, then I have bunch of stuff that I would like to change: https://github.com/slog-rs/slog/wiki/Things-to-make-different-next-time-around-(slog-v3%3F) |
|
On top of it, there is a discussion about having structured logging in So given all that, maybe it would be better to wait for |
|
If By the way, what will be the point of |
|
Contextual logging (pasing logging around with their associated KVs) is something that |
|
@dpc Still, structured logging is an important first step and is quite possibly more important due to the availability of |
|
From my understanding, developers working on |
|
@dpc didn't you want to close this instead of merging? |
|
I've decided to toy around with all of this stuff. I've created a v2 branch for stable version. |
The file, function, module str lifetimes was changed to not require
'static lifetimes. (As log 0.4 introduced for better interoperability).