Add ErrorRef wrapper
#327
Merged
Add ErrorRef wrapper
#327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the `ErrorRef` wrapper type. It enables to log error by reference, without moving ownership. It means that it is the non-owning counterpart of `ErrorValue`. Logging error references is an important use case for transparent logging middlewares. With this wrapper type, you can log the error and still pass it up the call stack. Such a wrapper type could already easily be implemented in user applications, but having it as part of Slog should help ergonomics. This also enables further improvements by integrating it with the Slog macros. Closes slog-rs#288
1 task
|
Unfortunately this does not support |
Techcable
added
C-enhancement
|
Thank you! Sorry for the delayed review. I will either open an issue or add a test for supporting |
Techcable
approved these changes
Jan 2, 2024
| key: Key, | ||
| serializer: &mut dyn Serializer, | ||
| ) -> Result { | ||
| serializer.emit_error(key, self.0) |
There was a problem hiding this comment.
Maybe we should add an emit_error_ref method with a default implementation?
It is unfortunate we have the 'static bound, but that's probably a requirement for things like slog_async. An alternative would be using format_args! and emit_arguments, but that would loose information 😦.
There was a problem hiding this comment.
That's a good point, may be worth adding it in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the
ErrorRefwrapper type. It enables to log error by reference, without moving ownership. It means that it is the non-owning counterpart ofErrorValue.Logging error references is an important use case for transparent logging middlewares. With this wrapper type, you can log the error and still pass it up the call stack.
Such a wrapper type could already easily be implemented in user applications, but having it as part of Slog should help ergonomics. This also enables further improvements by integrating it with the Slog macros.
Closes #288
Make sure to: