Give warnings when using old slog_ prefixed macros (ex. slog_log)
#331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are made redundant by the new 2018 paths. This warning can be disabled with the feature flag: suppress-macro2018-warnings
Techcable
force-pushed
the
macros/warn-rust-2018-paths
branch
from
dcca40f to
6fae64b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are made redundant by the new macro path system in Rust 2018. For example, we can now use
slog::log!()instead of needingslog_log!.This warning can be disabled with the feature flag:
suppress-macro2018-warningsTODO