Prefer Data.HashSet.member to Data.Foldable.elem (haskell#2886)

* Prefer Data.HashSet.member to Data.Foldable.elem * Remove unused binding Co-authored-by: Pepe Iborra <pepeiborra@gmail.com>
sloorush · May 21, 2022 · 7842379 · 7842379
1 parent 25fba0e
commit 7842379
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/ghcide/src/Development/IDE/Plugin/CodeAction/ExactPrint.hs b/ghcide/src/Development/IDE/Plugin/CodeAction/ExactPrint.hs
@@ -514,7 +514,6 @@ extendImportViaParent df parent child (L l it@ImportDecl{..})
           listAnn = epAnn srcParent [AddEpAnn AnnOpenP (epl 1), AddEpAnn AnnCloseP (epl 0)]
           x :: LIE GhcPs = reLocA $ L l'' $ IEThingWith listAnn parentLIE NoIEWildcard [childLIE]
 
-      let hasSibling = not (null pre)
       lies' <- addCommaInImportList (reverse pre) x
 #endif
       return $ L l it{ideclHiding = Just (hide, L l' lies')}

diff --git a/plugins/hls-rename-plugin/src/Ide/Plugin/Rename.hs b/plugins/hls-rename-plugin/src/Ide/Plugin/Rename.hs
@@ -161,7 +161,7 @@ renameRefs newName refs = everywhere $ mkT replaceLoc
         replace _                = Unqual newName
 
         isRef :: SrcSpan -> Bool
-        isRef = (`elem` refs) . unsafeSrcSpanToLoc
+        isRef = (`HS.member` refs) . unsafeSrcSpanToLoc
 
 ---------------------------------------------------------------------------------------------------
 -- Reference finding