Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
stream
kwarg ofread_env()
.Firstly, the kwarg is incorrectly type annotated. It is annotated as
str
and is passed as a kwarg todotenv.load_dotenv()
. That kwarg ofdotenv.load_dotenv()
, however, takes anio.StringIO
, not a string.Secondly, I believe the
stream
kwarg never does anything here.dotenv.load_dotenv()
only uses thestream
kwarg if its first kwarg (dotenv_path
) is falsy. It seems to me that we always pass a truthy value to that, sostream
is never used. Therefore I suggest we remove it.I recommend running mypy with access to site-packages and their typehints in CI (mypy in pre-commit runs in a venv with no site-packages, unless dependencies listed in .pre-commit-config.yaml). It would catch this and a few other issues.