Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cwe and cve roles #164

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Remove cwe and cve roles #164

merged 1 commit into from
Oct 12, 2024

Conversation

sloria
Copy link
Owner

@sloria sloria commented Oct 12, 2024

Close #162

@sloria sloria merged commit 7a2838f into main Oct 12, 2024
6 checks passed
@sloria sloria deleted the drop-cve-cwe branch October 12, 2024 02:02
@webknjaz
Copy link

@sloria why not keep them conditionally if Sphinx is below v8.1? Alternatively, perhaps add a dependency on Sphinx >= 8.1 so people on older versions wouldn't suddenly lose these roles?

@sloria
Copy link
Owner Author

sloria commented Nov 21, 2024

imo i don't think conditionally including the roles is worth the maintenance burden.

we could depend on sphinx>=8.1 but not sure if that's the best idea given that sphinx-issues is usable on older versions, just without the cwe and cve role.

perhaps for now we should add a note in the README that says: if you use the cwe and cve roles and are using Sphinx<8.1, you will need to install sphinx-issues<5.

@sloria sloria mentioned this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cve and cwe roles override Sphinx’s built-in roles
2 participants