use upload-artifact@v4 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
This was referenced Mar 18, 2024
ianlewis
approved these changes
Mar 18, 2024
| @@ -68,7 +68,7 @@ runs: | |||
| # builders are run concurrently. This is simplified | |||
| # for our e2e tests. | |||
| - name: Upload the artifact | |||
| uses: actions/upload-artifact@v3 | |||
| uses: actions/upload-artifact@v4 | |||
There was a problem hiding this comment.
Might we want to pin these to a version as well? example-package is in many ways more problematic security-wise than slsa-github-generator repo since example-package has access to highly privileged PAT tokens.
There was a problem hiding this comment.
this repo only contains example. Either we pin it and we'll never update, or we keep a floating version. I'm fine pinning so long as dependabot is not enabled :)
laurentsimon
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Thanks. I'll wait for a decision on @ianlewis 's comment to merge.
Ping me on the thread when it's ready to merge
|
@ianlewis please take another look |
ianlewis
approved these changes
Apr 3, 2024
| @@ -68,7 +68,7 @@ runs: | |||
| # builders are run concurrently. This is simplified | |||
| # for our e2e tests. | |||
| - name: Upload the artifact | |||
| uses: actions/upload-artifact@v3 | |||
| uses: actions/upload-artifact@v4 | |||
ramonpetgrave64
added a commit
to slsa-framework/slsa-github-generator
that referenced
this pull request
Apr 3, 2024
…act v4"" (#3499) Reverts #3398 Following up with - slsa-framework/example-trw#3 - slsa-framework/example-package#340 - slsa-framework/slsa-verifier#719 Signed-off-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup to slsa-framework/example-package#336
fixes e2e test
will followup in slsa-framework/example-package#340