Skip to content

Commit

Permalink
fix: maven e2e: remove verify job (#3748)
Browse files Browse the repository at this point in the history
# Summary

Followup to #3746 

Removes the verify job, which won't work, because the ref will be
incorrect.

-
https://github.com/slsa-framework/slsa-github-generator/actions/runs/10115454784/job/27976327657#step:5:1

```
WARNING: Insecure SLSA_VERIFIER_TESTING is enabled.
Verifying artifact ./target/test-java-project-1.21.97.jar: FAILED: invalid ref: "refs/heads/main": unexpected ref type: "heads"

FAILED: SLSA verification failed: invalid ref: "refs/heads/main": unexpected ref type: "heads"
Error: Process completed with exit code 1.
```

## Testing Process

The e2e test is executed in this PR, which now passes.

## Checklist

- [x] Review the contributing
[guidelines](https://github.com/slsa-framework/slsa-github-generator/blob/main/CONTRIBUTING.md)
- [x] Add a reference to related issues in the PR description.
- [ ] Update documentation if applicable.
- [x] Add unit tests if applicable.
- [ ] Add changes to the
[CHANGELOG](https://github.com/slsa-framework/slsa-github-generator/blob/main/CHANGELOG.md)
if applicable.

---------

Signed-off-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
  • Loading branch information
ramonpetgrave64 authored Jul 26, 2024
1 parent 6f49f01 commit afa0f38
Showing 1 changed file with 0 additions and 22 deletions.
22 changes: 0 additions & 22 deletions .github/workflows/pre-submit.e2e.maven.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,25 +33,3 @@ jobs:
uses: slsa-framework/slsa-github-generator/.github/workflows/builder_maven_slsa3.yml@main
with:
directory: ./e2e/maven/workflow_dispatch

verify:
runs-on: ubuntu-latest
needs: [build]
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- uses: slsa-framework/slsa-github-generator/actions/maven/secure-download-attestations@main
with:
name: "${{ needs.build.outputs.provenance-download-name }}"
sha256: "${{ needs.build.outputs.provenance-download-sha256 }}"
path: ./
- uses: slsa-framework/slsa-github-generator/actions/maven/secure-download-target@main
with:
name: "${{ needs.build.outputs.target-download-name }}"
sha256: "${{ needs.build.outputs.target-download-sha256 }}"
path: ./
- uses: slsa-framework/slsa-verifier/actions/installer@v2.6.0
- name: Verify artifact
env:
PROVENANCE_PATH: ${{ needs.build.outputs.provenance-download-name }}
TARGET_PATH: ${{ needs.build.outputs.target-download-name }}
run: slsa-verifier verify-artifact "$TARGET_PATH" --provenance-path "$PROVENANCE_PATH"

0 comments on commit afa0f38

Please sign in to comment.