Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Use upstream version of npm for publishing #1897

Closed
ianlewis opened this issue Mar 31, 2023 · 4 comments · Fixed by #2257
Closed

[feature] Use upstream version of npm for publishing #1897

ianlewis opened this issue Mar 31, 2023 · 4 comments · Fixed by #2257
Labels
area:nodejs Issue related to the Node.js builder type:feature New feature or request
Milestone
Node.js builder GA

Comments

@ianlewis
Copy link
Member

We currently use a fork of the npm cli for publishing to npmjs.com. We need to merge a change to allow out-of-band provenance.

Related to https://github.com/gh-community/npm-provenance-private-beta-community/issues/11
Related to npm/cli#6300
@ianlewis ianlewis added the type:feature New feature or request label Mar 31, 2023
@ianlewis ianlewis added this to the Node.js builder GA milestone Mar 31, 2023
@ianlewis ianlewis added the area:nodejs Issue related to the Node.js builder label Mar 31, 2023
@ianlewis ianlewis mentioned this issue Mar 31, 2023
Closed
@ianlewis
Copy link
Member Author

Blocked on https://github.com/gh-community/npm-provenance-private-beta-community/issues/11 which is, in turn, blocked on npm/cli#6313

@ianlewis ianlewis added the status:blocked This issue is currently blocked and can't make progress. label Apr 11, 2023
@ianlewis
Copy link
Member Author

Blocked by npm/cli#6455

@ianlewis
Copy link
Member Author

The PR we are blocked on is: npm/cli#6490

@ianlewis
Copy link
Member Author

ianlewis commented Jun 8, 2023

npm 9.7.0 was released and includes the new --provenance-file flag. We can now update the builder to use this version of npm.

@ianlewis ianlewis removed the status:blocked This issue is currently blocked and can't make progress. label Jun 8, 2023
@ianlewis ianlewis mentioned this issue Jun 8, 2023
Merged
ianlewis added a commit that referenced this issue Jun 15, 2023
@ianlewis
feat: Use upstream npm for uploading provenance. (#2257)
9b3d983 
Fixes #1897

---------

Signed-off-by: Ian Lewis <ianlewis@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:nodejs Issue related to the Node.js builder type:feature New feature or request
Projects
None yet
Milestone
Node.js builder GA
Development

Successfully merging a pull request may close this issue.

feat: Use upstream npm for uploading provenance. ianlewis/slsa-github-generator
1 participant
@ianlewis