feat: update Gradle builder to accomodate for e2e test #2636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AdamKorcz <44787359+AdamKorcz@users.noreply.github.com>
AdamKorcz
requested review from
asraa,
ianlewis,
laurentsimon,
joshuagl and
kpk47
as code owners
laurentsimon
changed the title
laurentsimon
approved these changes
Aug 15, 2023
…out PROJECT_ROOT being validated Signed-off-by: AdamKorcz <adam@adalogics.com>
Signed-off-by: AdamKorcz <adam@adalogics.com>
|
@laurentsimon @ianlewis please have a look. |
ianlewis
reviewed
Aug 18, 2023
|
Ug, forgot to submit my review comments from 2 days ago... |
laurentsimon
pushed a commit
that referenced
this pull request
Aug 18, 2023
Fixes #2643 The following comments are irrelevant and have not been addressed: 1. #2636 (comment) (was already done) 2. #2636 (comment) (the code has been removed) @ianlewis @laurentsimon PTAL Signed-off-by: AdamKorcz <adam@adalogics.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found these changes to be necessary to run the Gradle e2e test.