fix(deps): update go to 1.21 #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mend Renovate <bot@renovateapp.com> Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
This reverts commit e8befa2. Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
This reverts commit 0bc2c70. Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
This reverts commit 8c346b8. Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
ramonpetgrave64
force-pushed
the
ramonpetgrave64-update-go-1.21
branch
from
4981e1e
to
a24f036
Compare
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
This reverts commit f468545. Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
ramonpetgrave64
force-pushed
the
ramonpetgrave64-update-go-1.21
branch
from
7dda203
to
f2d691f
Compare
laurentsimon
approved these changes
Jan 22, 2024
|
Enabling auto-merge |
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
auto-merge was automatically disabled
January 23, 2024 17:30
Head branch was pushed to by a user without write access
ianlewis
reviewed
Jan 24, 2024
| # TODO(2680): re-enable go-version-file | ||
| # go-version-file: "go.mod" | ||
| go-version: '1.20' | ||
| go-version-file: "go.mod" |
There was a problem hiding this comment.
What was the issue with using go-version-file before? I guess we fixed it in 1.9.0.
There was a problem hiding this comment.
I'm not sure what the issue was before, but using go-version-file instead of go-version lets use specify which version to use in only one place.
There was a problem hiding this comment.
Yeah, I remember we fixed an issue with it and maybe that was in 1.9.0?
slsa-framework/slsa-github-generator#2661
But it looks like we haven't released that fix yet.
slsa-framework/slsa-github-generator@00c744f
ianlewis
approved these changes
Jan 24, 2024
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the existing PR #498 to also change the github actions to use the go 1.21 sourced directly from
go.mod.Also fixing some more lint checks about repeated strings