Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slsa.dev 2.0 (PR 1/x): Content and structure updates #118

Merged
merged 6 commits into from
Aug 3, 2021

Conversation

devmoran
Copy link
Contributor

  • Adds subpages and content
  • New docs/index.md
  • Updates project README

To be followed by a PR for layout and styling updates

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
docs/getinvolved.md Outdated Show resolved Hide resolved
Copy link
Member

@MarkLodato MarkLodato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Dev! Sorry for so many comments - it's a big PR! :-D

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/getinvolved.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/requirements.md Outdated Show resolved Hide resolved
docs/requirements.md Outdated Show resolved Hide resolved
docs/roadmap.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
@devmoran devmoran force-pushed the main branch 2 times, most recently from 0693f28 to 805435d Compare August 2, 2021 17:19
Signed-off-by: Dev Morgan <disfordisford@gmail.com>
@MarkLodato
Copy link
Member

Regarding the link renaming, we're using markdownlint-cli instead of prettier since the former is less opinionated.

Signed-off-by: Dev Morgan <disfordisford@gmail.com>
@inferno-chromium
Copy link
Contributor

@devmoran - looks like linter is failing.
Can you please do that definition update (see comment above) and these minor lint fixes

docs/getinvolved.md:3 MD001/heading-increment/header-increment Heading levels should only increment by one level at a time [Expected: h2; Actual: h4]
docs/getinvolved.md:7 MD001/heading-increment/header-increment Heading levels should only increment by one level at a time [Expected: h3; Actual: h4]
docs/levels.md:3 MD001/heading-increment/header-increment Heading levels should only increment by one level at a time [Expected: h2; Actual: h4]
docs/levels.md:53 MD036/no-emphasis-as-heading/no-emphasis-as-header Emphasis used instead of a heading [Context: "○ = required unless there is a..."]
docs/requirements.md:3 MD001/heading-increment/header-increment Heading levels should only increment by one level at a time [Expected: h2; Actual: h4]
use_cases.md:80:1 MD005/list-indent Inconsistent indentation for list items at the same level [Expected: 4; Actual: 6]
use_cases.md:81:1 MD005/list-indent Inconsistent indentation for list items at the same level [Expected: 4; Actual: 6]
Error: Process completed with exit code 1.

Signed-off-by: Dev Morgan <disfordisford@gmail.com>
Signed-off-by: Mark Lodato <lodato@google.com>
Signed-off-by: Mark Lodato <lodato@google.com>
@MarkLodato
Copy link
Member

I pushed a few cleanup commits but otherwise LGTM. Thanks, Dev and company!

@MarkLodato MarkLodato merged commit 9dd364f into slsa-framework:main Aug 3, 2021
@inferno-chromium
Copy link
Contributor

Thanks @devmoran and @MarkLodato !

MarkLodato added a commit to MarkLodato/slsa that referenced this pull request Aug 10, 2021
This got lost in the major slsa-framework#118 update.

Signed-off-by: Mark Lodato <lodato@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants