Avoid error messages because of hard links #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting of a Docker container can show an error because
creating hard links is not possible across filesystems:
ln: failed to create hard link '/models/ocrd-resources/ocrd-tesserocr-recognize/eng.traineddata' => '/usr/local/share/tessdata/eng.traineddata': Invalid cross-device link
ln: failed to create hard link '/models/ocrd-resources/ocrd-tesserocr-recognize/equ.traineddata' => '/usr/local/share/tessdata/equ.traineddata': Invalid cross-device link
ln: failed to create hard link '/models/ocrd-resources/ocrd-tesserocr-recognize/osd.traineddata' => '/usr/local/share/tessdata/osd.traineddata': Invalid cross-device link
In addition, restarting an existing Docker container will
always give an error because the hard links already exist.
Using forced symbolic links fixes both kinds of errors.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
bertsky
reviewed
Nov 9, 2022
There was a problem hiding this comment.
Yes, sorry about that – a last-minute change I thought I had tested but did not.
The problem I still have with this setup is that the files on the host side will point to path names inside the container. Since we are talking of just a few megabytes (for the default models we install along with make install-tesseract), I think we should rather cp than ln after all.
bertsky
reviewed
Nov 9, 2022
Co-authored-by: Robert Sachunsky <38561704+bertsky@users.noreply.github.com>
stweil
commented
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting of a Docker container can show an error because creating hard links is not possible across filesystems:
In addition, restarting an existing Docker container will always give an error because the hard links already exist.
Using forced symbolic links fixes both kinds of errors.
Signed-off-by: Stefan Weil sw@weilnetz.de