Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: add label-schema and OCI labels #31

Merged
merged 3 commits into from
May 3, 2023

Conversation

bertsky
Copy link
Member

@bertsky bertsky commented May 2, 2023

perhaps better this way. But I have no idea how org.opencontainers.image.base.digest is supposed to be set within Dockerfile (short of another BUILD_ARG), so I just left it out.

@bertsky bertsky requested a review from markusweigelt May 2, 2023 11:52
@bertsky bertsky mentioned this pull request May 2, 2023
remove metadata-action from workflow
@bertsky
Copy link
Member Author

bertsky commented May 2, 2023

Before you merge, can we trigger GHA here and take a look at the labels, comparing before/after?

add description and documentation url
Dockerfile Show resolved Hide resolved
@markusweigelt
Copy link
Collaborator

markusweigelt commented May 2, 2023

Before you merge, can we trigger GHA here and take a look at the labels, comparing before/after?

Yes I have created an image to test labels.

https://github.com/slub/ocrd_controller/pkgs/container/ocrd_controller/90000776?tag=labeltest

@bertsky
Copy link
Member Author

bertsky commented May 2, 2023

Yes I have created an image to test labels.

https://github.com/slub/ocrd_controller/pkgs/container/ocrd_controller/90000776?tag=labeltest

That's odd. GH does not show any. docker image inspect does show all the OCI labels under Config, but there's also a null under ContainerConfig – no idea what relevance that has.

@markusweigelt
Copy link
Collaborator

That's odd. GH does not show any. docker image inspect does show all the OCI labels under Config, but there's also a null under ContainerConfig – no idea what relevance that has.

My internet is so lame i am still downloading :/

@markusweigelt markusweigelt merged commit 1db99b0 into master May 3, 2023
@markusweigelt markusweigelt deleted the dockerfile-labels branch May 3, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants